Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve the URI query in ProxyGetRequest::call #1512

Merged
merged 3 commits into from
Jan 8, 2025
Merged

fix: preserve the URI query in ProxyGetRequest::call #1512

merged 3 commits into from
Jan 8, 2025

Conversation

dcfreire
Copy link
Contributor

@dcfreire dcfreire commented Jan 7, 2025 •
edited
Loading

@dcfreire dcfreire requested a review from a team as a code owner January 7, 2025 19:57
@dcfreire dcfreire mentioned this pull request Jan 7, 2025
Closed
@carneiro-cw carneiro-cw mentioned this pull request Jan 7, 2025
Merged
@niklasad1 niklasad1 requested a review from lexnv January 8, 2025 08:35
niklasad1
niklasad1 reviewed Jan 8, 2025
View reviewed changes
server/src/middleware/http/proxy_get_request.rs
@@ -149,8 +150,12 @@ where
(Some(method), &Method::GET) => {
// RPC methods are accessed with `POST`.
*req.method_mut() = Method::POST;
// Precautionary remove the URI.
*req.uri_mut() = Uri::from_static("/");
// Precautionary remove the URI path.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//cc @lexnv do you remember why we removed the URI in the first place?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite remember 🤔

@niklasad1 niklasad1 merged commit 0ab5b09 into paritytech:master Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcfreire @niklasad1 @lexnv